Add retry timeout when fetching oidc_endpoints #1085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #1046
Currently any
retry_timeout_secondspassed into theConfigis not passed along to other methods or properties, such asoidc_endpoints. This is an issue because it can lead to the instantiation of theConfigclass taking 5 minutes if an invalid host is provided (this is the default timeout).This PR ensures the
retry_timeout_secondsis respected when fetching account and workspace endpoints.How is this tested?
Prior to this PR, this code will fail after 5 minutes:
After this change, it will fail after 30 seconds as expected: